Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inheritdoc #775

Merged
merged 4 commits into from
Oct 2, 2024
Merged

feat: inheritdoc #775

merged 4 commits into from
Oct 2, 2024

Conversation

0xClandestine
Copy link
Contributor

No description provided.

@0xClandestine
Copy link
Contributor Author

Not currently compiling, we're missing interface definitions for many functions...

Copy link
Collaborator

@ypatil12 ypatil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we validate the natspec in the interface matches what we remove? IIRC some of these do not align properly.

@0xClandestine
Copy link
Contributor Author

Can we validate the natspec in the interface matches what we remove? IIRC some of these do not align properly.

Imo natspec needs a rework overall, lots of inconsistent format/grammar/punctuation.

@ypatil12 ypatil12 force-pushed the feat/inherit-natspec-from-interfaces branch from 6813cf2 to 1064275 Compare October 2, 2024 17:22
@0xClandestine 0xClandestine merged commit 6f43c63 into dev Oct 2, 2024
15 of 19 checks passed
@0xClandestine 0xClandestine deleted the feat/inherit-natspec-from-interfaces branch October 2, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants